HomeCategoriesChoose a templateRecent Entries
|
Monday, August 31. 2009Help needed for final libsoup2.4 fixes in drivel 3.0
Drivel 3.0.0 (current SVN trunk) is now ready for GTK+3.0. libegg has gone, there is one remaining issue with the GtkRecentChooser replacement. libgnome and libgnomeui are going away too and these have been dropped from drivel (therefore bonobo has gone too). gtksourceview has been migrated from 1.0 to 2.0. GtkSpell now correctly finds all supported dictionaries and a whole load of console messages about invalid casts etc. have been fixed. There is no libglade anymore, it's GtkBuilder throughout. Essentially, everything needed to bring drivel up to date with GTK+3 is in place.
Problems.
debcheckout still has the old GNOME details until 3.0 is uploaded, so the SVN details at SF are: svn co https://drivel.svn.sourceforge.net/svnroot/drivel drivel SF homepage: http://drivel.sourceforge.net/ Dev mailing list (for bugs and patches) http://mail.gnome.org/mailman/listinfo/drivel-list Or just send me the patches direct (email details in the source files). posted with 2.0.4 If you want to test all the various clients, you'll need wordpress, movabletype-opensource and serendipity installed as Debian packages (and configured) and accounts at advogato, livejournal and blogger. So, dear lazyweb, anyone got some ideas? Trackbacks
Trackback specific URI for this entry
No Trackbacks
Comments
Display comments as
(Linear | Threaded)
can you describe the "not updating itself" part? are you using the GtkRecentManager API to add a new item to the recently used list?
I've looked at the code, and apart from the call to gtk_recent_manager_set_limit() in journal.c (which should not be used unless you're implementing a GtkRecentChooser yourself) I can't see anything obviously wrong.
yes, as I thought: the call to gtk_recent_manager_set_limit() is what's blocking your menu. the set_limit() function sets the limit of the unfiltered list returned by gtk_recent_manager_get_items() - which is what RecentChooser implementations use. if your recently used files list is longer than 4 items, and the first draft you save falls after those 4, it will never be displayed.
you should let GtkRecentChooserMenu display the correct amount of items (a maximum of 15, as per the GNOME human interface guidelines). so, the patch is as trivial as: - gtk_recent_manager_set_limit (dc->recent_manager, 4); inside src/login.c at line 1138.
The patch is simple, thanks - but I would like the Recent Drafts submenu to be 4 lines long, not 25.
Is there some way of doing that? On a different note, there was a drivel.draft in the Recent Documents menu during testing - it was #1 in the list but it didn't show up in drivel - at all. I suspect there is more going on here than just the limit of 4. If the limit is applied before the filter, isn't that a bug in GTK? OK, 15 not 25, but I'd still prefer 4.
the problem here is that gtk_recent_manager_set_limit() is not meant to be used unless you're implementing your own recent chooser widget - which you aren't. remember: GtkRecentManager is the data model; GtkRecentChoosers are the view of the data model. if you change the data model and its behaviour you affect the views.
if you want to set the limit of items to be displayed you should be using gtk_recent_chooser_set_limit() on the GtkRecentChooserMenu; this will set the limit to the required value and it will be done after the filter is in place.
OK, thanks, I'll try with this change:
- gtk_recent_manager_set_limit (dc->recent_manager, 4); + gtk_recent_chooser_set_limit(dc->recent_chooser, 4); I'll get back to testing the actual refresh tomorrow. |
ArchivesSyndicate This BlogQuicksearch |
